Felix Singer submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Jonathon Hall: Looks good to me, but someone else must approve
atapromise.c: Use fallback_map instead of own identical implementation

Change-Id: Iea16d42015bdbe838364cc65cff895d9edaf03a7
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67655
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathon Hall <jonathon.hall@puri.sm>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M atapromise.c
1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/atapromise.c b/atapromise.c
index 63463f5..d4a3aa8 100644
--- a/atapromise.c
+++ b/atapromise.c
@@ -54,12 +54,6 @@
{0},
};

-static void *atapromise_map(const char *descr, uintptr_t phys_addr, size_t len)
-{
- /* In case fallback_map ever returns something other than NULL. */
- return NULL;
-}
-
static void atapromise_limit_chip(struct flashchip *chip, size_t rom_size)
{
unsigned int i, size;
@@ -190,7 +184,7 @@
.type = PCI,
.devs.dev = ata_promise,
.init = atapromise_init,
- .map_flash_region = atapromise_map,
+ .map_flash_region = fallback_map,
.unmap_flash_region = fallback_unmap,
.delay = internal_delay,
};

To view, visit change 67655. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea16d42015bdbe838364cc65cff895d9edaf03a7
Gerrit-Change-Number: 67655
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged