Jonathan Zhang has uploaded this change for review.

View Change

ichspi: print transaction error in debug mode

When "--fmap" option is used, flashrom does binary search in flash for
fmap. When it reads flash region that is locked, transaction error happens.

Print transaction error in debug mode, so that following message:
Transaction error between offset 0x02cb4000 and 0x02cb4007 (= 0x02cb4000 + 7)!
shows up only when "-V" is specified.

Change-Id: Iebed1ae7f15b7f06b90a0b5947b953f7f0e1567d
Signed-off-by: Jonathan Zhang <jonzhang@fb.com>
---
M ichspi.c
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/49001/1
diff --git a/ichspi.c b/ichspi.c
index 4209d60..6dde7b2 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1311,11 +1311,17 @@

if (hsfs & HSFS_FCERR) {
addr = REGREAD32(ICH9_REG_FADDR) & hwseq_data.addr_mask;
- msg_perr("Transaction error between offset 0x%08x and "
+
+ /*
+ * If the partition is locked, this transaction error happens.
+ * Print in verbose mode to avoid excessive messages.
+ */
+ msg_cdbg("Transaction error between offset 0x%08x and "
"0x%08x (= 0x%08x + %d)!\n",
addr, addr + len - 1, addr, len - 1);
prettyprint_ich9_reg_hsfs(hsfs, ich_gen);
prettyprint_ich9_reg_hsfc(REGREAD16(ICH9_REG_HSFC), ich_gen);
+
return 1;
}
return 0;

To view, visit change 49001. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iebed1ae7f15b7f06b90a0b5947b953f7f0e1567d
Gerrit-Change-Number: 49001
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-MessageType: newchange