David Hendricks posted comments on this change.

View Change

Patch set 1:Code-Review +2

I like the clean-up that this accomplishes, so LGTM.

Bikeshed: We may want to revisit the name or meaning of "internal" to not exclude ARM and other architectures. The naming is sort of confusing when considering linux_spi and (soon) linux_mtd which also control an internal programmer interface.

To view, visit change 22671. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672ddab0415df3baa49ff39a1c9db1b41d8143a4
Gerrit-Change-Number: 22671
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 20:00:42 +0000
Gerrit-HasComments: No