Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #2, Line 558:

    if (data)
    		free(data);
    

    The check is redundant. Remember that CB:54905 has an explanation? 😊 […]

    Oh yes... done! thank you!

    I didn't add a comment, but tell me if I misunderstood you, if you think this can benefit from a comment I can compose something.
     
    The other thing about "it would be a bug in the programmer code anyway", yes - but not for long! :) We are walking on the route to move data alloc and free into the core. And then, it would be a bug in the register_master code (not in programmer code). Good thing there is only one register_master vs many many programmers.

To view, visit change 54890. To unsubscribe, or for help writing mail filters, visit settings.