Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

Patch set 12:Code-Review +1

View Change

2 comments:

• File dummyflasher.c:

  • Patch Set #10, Line 264: /* XXX: should data->erase_to_zero be taken into account here? */

    It does look like a bug to me, thanks! […]

    +1, preserving the current behavior with a FIXME comment is the best option IMO.

• File dummyflasher.c:

  • Patch Set #12, Line 236:

    	if (start >= data->wp_start && start < data->wp_end)
    		return true;
    
    	const uint32_t last = start + len - 1;
    	return (last >= data->wp_start && last < data->wp_end);
    

    These two tests can be combined as:

    const uint32_t last = start + len - 1;
    return (start < data->wp_end && last >= data->wp_start);

    Actually they need to combined to catch the theoretical case where the region being written strictly contains the protection region. Although that isn't an issue for now since most chips only have protection regions at one end of address space.

To view, visit change 59074. To unsubscribe, or for help writing mail filters, visit settings.