PS13 addresses a couple lingering issues from earlier patch sets.

I also came up with a patch to try and implement the original intended behavior for '-w':

It's a bit hacky though, though it does allow us to keep the policy decision in the CLI code. There might be a better way.

View Change


To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 13
Gerrit-Owner: David Hendricks <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: Carl-Daniel Hailfinger <>
Gerrit-Reviewer: David Hendricks <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Nicola Corna <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Mon, 22 Jan 2018 08:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No