Attention is currently required from: Edward O'Callaghan, Tom Hughes.
View Change
3 comments:
Commit Message:
Patch Set #1, Line 14: TEST=emerge-hatch flashrom
If you could test that pre-processor output is the same before and after, that would be perfect!
Patchset:
File layout.h:
Patch Set #1, Line 33: PRIxCHIPOFF
I can't find usages of PRIxCHIPOFF and PRIuCHIPSIZE... what I am missing? Is there some concatenation somewhere that makes the usages hard to find?
To view, visit change 63000. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04f5572d6c2dc27b7c54ee6ee97874a7a1940229
Gerrit-Change-Number: 63000
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Hughes <tomhughes@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Tom Hughes <tomhughes@chromium.org>
Gerrit-Comment-Date: Wed, 13 Apr 2022 02:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment