Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Victor Lim.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 8056: reg_bits
Nikolai, I wanted to check with you, if srp is not defined in datasheet , is it fine to not define i […]
We should leave the srp bits out of reg_bits if the chip doesn't have them, but I'm not sure how the chip would support write protection without the SRP0 bit.
To view, visit change 84090. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ibbbbb8a55adbcbc2ee1785782c4eb3771d50c167
Gerrit-Change-Number: 84090
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Lim <vlim@gigadevice.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Victor Lim <vlim@gigadevice.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 11 Oct 2024 00:07:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>