Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    Without any reasoning given as to why this functionality is necessary, I think this patch is harmful […]

    https://en.wikipedia.org/wiki/Serial_Peripheral_Interface

    I read the data sheet of W25Q128FV, it can work in mode0 and mode3, it just works. We can't keep the code just because it just works.

• File bitbang_spi.c:

  • Patch Set #1, Line 78: bitbang_spi_xfer(

    I would not approve of such a patch either. […]

    Splitting independent reading and writing is indeed good for speed

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.