Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.

View Change

4 comments:

• File vl805.c:

  • Patch Set #3, Line 38: static struct pci_dev *dev = NULL;

    Still lost on what you are trying to say, did you mean flashctx instead of flashxtx? […]

    The point I'm trying to make is that the `struct pci_dev *dev` should NOT be a global variable. It should be contained in a data structure, allocated in `vl85_init()` , used as second parameter in `register_spi_master()` and passed along to `vl805_spi_send_command` via `flash->mst->data`.

    You may want to look into other programmer calling `register_spi_master()` with the second parameter being not `NULL`.

• File vl805.c:

  • Patch Set #10, Line 103: static const struct spi_master spi_master_vl805 = {

    Add `.shutdown = vl805_shutdown,`

  • Patch Set #10, Line 120: static int vl805_shutdown(void *data)

    This has to move above `struct spi_master`

  • Patch Set #10, Line 157: register_shutdown(vl805_shutdown, NULL);

    The `register_shutdown()` can be removed. It is handled as part of the `struct spi_master`

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.