Patch Set 1: Code-Review-1

Patch Set 1:

Also, the CDS timeout would be announced through either a an actual timeout or through FCERR aborting the loop. This cosmetic incorrectness is there with and without this patch.

Overall I think the error message should distinguish between those two exit criteria, but (the rest of) this patch should be abandoned.

And I should have kept reading. The code is actually already doing this correctly without any patch. So it should be fine to just abandon this, as it is a no-op as far as I can tell

Good point, thanks for noticing.

Perfect ! Thanks for the analysis and the background Stefan! I guess that means we should remove it on CrOS side then.

View Change

To view, visit change 46325. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93198cb8536705e9b71b7fbe43a20e151c2a72a8
Gerrit-Change-Number: 46325
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 17 Oct 2020 01:04:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment