I will augment the commit message

View Change

2 comments:

• Commit Message:

  • Patch Set #6, Line 10: some things

    Mention it was necessary to change the type of the base address variables?

    Ack

• File nicintel_spi.c:

  • Patch Set #6, Line 110:

    {PCI_VENDOR_ID_INTEL, 0x151f, NT, "Intel", "I350 Gigabit Network Connection Unprogrammed"},
    	{PCI_VENDOR_ID_INTEL, 0x1521, NT, "Intel", "I350 Gigabit Network Connection Copper"},
    	{PCI_VENDOR_ID_INTEL, 0x1522, NT, "Intel", "I350 Gigabit Network Connection Fiber"},
    	{PCI_VENDOR_ID_INTEL, 0x1523, NT, "Intel", "I350 Gigabit Network Connection 1000BASE-KX / 1000BASE-BX backplane"},
    	{PCI_VENDOR_ID_INTEL, 0x1524, NT, "Intel", "I350 Gigabit Network Connection External SGMII PHY"},
    

    None of these are tested?

    Yes, we abandoned the SPI for our product and I do not have the time to add the chips back to my Intel produced PCIe I350 that I used as a reference.

To view, visit change 39963. To unsubscribe, or for help writing mail filters, visit settings.