Attention is currently required from: Thomas Heijligen.
Patch set 2:Code-Review +2
View Change
1 comment:
File tests/lifecycle.c:
Patch Set #2, Line 87: #if CONFIG_DUMMY == 1
We could get rid of the pre-processor conditionals by splitting up the file into per-driver compilation units and using a weak symbol entry point then letting the linker do the rest for us.
To view, visit change 64224. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I02880e73996b30df618738e86b8a52126fbe5b3b
Gerrit-Change-Number: 64224
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Wed, 11 May 2022 23:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment