Attention is currently required from: Peter Marheine.

View Change

2 comments:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #4, Line 82: // an operation must provide a file or a region.file or both.

    Does this vary with what operation is being performed? It might be more obvious (regarding correct u […]

    I tried it a bit like this way initially, I didn't like that the things inside the enum variants dont have names. I suppose I could put a struct in each though.

    I did not notice that Erase can have a region, but I'm not using it yet so I'll leave it off.

  • Patch Set #4, Line 148: #[allow(clippy::needless_update)] // clippy doesnt like Default when all fields are filled

    Seems okay to omit the `default` then, unless you anticipate adding more fields that would require a […]

    I had thought the point of it was to save me if I add a field back in and forget to modify this site. I think I am misunderstanding

To view, visit change 71973. To unsubscribe, or for help writing mail filters, visit settings.