Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #15:
Besides the at45db changes, looks OK. […]
I've done what you have asked of me https://review.coreboot.org/c/flashrom/+/69131
Although this change was extensively tested as well as has a breakdown into its constituents (abandon patches) from which it was squashed together.
Personally I feel there is more opportunity to introduce bugs messing around between representations between commits even though your idea in principle is good. In any case I have done what you have asked in CB:69131
To view, visit change 67240. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I58415a4f2589812b26d284c96876e88f8d9acf52
Gerrit-Change-Number: 67240
Gerrit-PatchSet: 15
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 01:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment