Attention is currently required from: Anastasia Klimchuk.

View Change

1 comment:

• File hwaccess_x86_io_unittest.h:

  • Patch Set #19, Line 41: #include <sys/io.h>

    If we're mocking I/O access, we most likely don't need to use system headers.

    I just tested what is missing to compile on Linux: Just the forward
    declarations of the i/o functions and iopl().

    The former are not even used with `hwaccess_x86_io_unittest.h` and
    the latter, it seems, we forgot to mock anyway ;) so simply replacing
    the #include with this might be enough:

        static inline int iopl(int level) { return 0; }

    I am heavily confused now, how the tests work without it?

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.