Attention is currently required from: Nico Huber, Victor Ding, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #1:
Sorry that I don't have a precise answer atm. […]
Victor, thank you, if you could get this information that would be great!
I saw those two were upstreamed last year (relatively recently), so I was assuming they are useful... I wrote tests for them :\ Actually, this is how I found out that write_aai is missing, because tests failed on the next patch CB:56103.
It would be extremely ironic if the tests have found the problem, the solution to which is to remove the code and tests... but anyway if I've made a mistake I will fix it.
To view, visit change 56102. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Gerrit-Change-Number: 56102
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Victor Ding <victording@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Victor Ding <victording@google.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 09 Jul 2021 09:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Victor Ding <victording@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment