Attention is currently required from: Nico Huber, Stefan Reinauer, Anastasia Klimchuk.

View Change

1 comment:

• Commit Message:

  • Patch Set #4, Line 14:

    The user of the registered_masters type is therefore
    responsible for querying the buses_supported field before
    attempting to dereference a ptr field in the anon struct.
    

    Can the user check which one out of three is not null?

    It's a good question. I guess I mean "user" here to mean things that call "spi_send_command()" such as in spi25.c.

    The actual case where this exploded was when w25q_read_status_register_2() used spi_send_command(), which requires that the master be a spi_master where as Hardware-sequenced ICH that is an opaque master was being used.

    Essentially the union is a bit of a trap.

To view, visit change 50246. To unsubscribe, or for help writing mail filters, visit settings.