4 comments:

File ni845x_spi.c:
- Patch Set #25, Line 253: if (io_voltage_100mV < usb8452_io_voltages_in_100mV[0]) {
  Nit, if called with `use_smaller = false` we might not want to take this path? […]
  Ack
- Patch Set #25, Line 443: if (device_pid == USB8451) {
  Nit, taking this path will result in no warning printed, even if […]
  Ack
- Patch Set #25, Line 504: return -1;
  This path is a little troubling. What if the user has a voltage translator […]
  Ack
- Patch Set #25, Line 542: }
  Might look nicer with the whole `if` block in a separate fucntion.
  Ack

To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.