Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #5:
I didn't take a look at the code, but I imagine this tries to use a full chip erase command where po […]
The clou is the condition
```
if ((block_size == flashctx->chip->total_size * 1024) && per_blockfn == &erase_block){
```
So when the block size equals the flash size it uses the biggest possible erase block size (assuming the eraseblocks are always given in ascending order).
I have never worked with a layout that´s why I didn´t test it. However in case of a given layout the "normal" way should be taken.
To view, visit change 58467. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b
Gerrit-Change-Number: 58467
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 09:46:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Buhrow
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment