Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

Patch set 7:Code-Review -1

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Oh alright I got it. All good, I appreciate your help anyway! […]

    asked for help on #flashrom and #coreboot

• Patchset:

  • Patch Set #7:

    nic3-14159 from #flashrom kindly helped me and tested this patch on a machine with ich7 chipset, and found a bug:

     "@aklm I ran it through GDB and found that ich_spibar is never set to spibar in the init_ich7_spi codepath, leaving it with the initial NULL value that leads to the segfault. .... Looks like ich_generation is also never changed from CHIPSET_ICH_UNKNOWN in the init_ich7_spi codepath"

    I give this -1 until I fix.

To view, visit change 58735. To unsubscribe, or for help writing mail filters, visit settings.