Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #5, Line 948: if (bustype & (1 << i))

    why this condition is needed?

    This condition checks if a specific bus is enabled (`bustype` is a bit flag variable). Instead of using constants from `enum chipbustype` (because we cannot do it in the loop), use the same bit shifting technique:

    ```
    enum chipbustype {
    	BUS_NONE	= 0,
    	BUS_PARALLEL	= 1 << 0,
    	BUS_LPC		= 1 << 1,
    	BUS_FWH		= 1 << 2,
    	BUS_SPI		= 1 << 3,
    	BUS_PROG	= 1 << 4,
    	BUS_NONSPI	= BUS_PARALLEL | BUS_LPC | BUS_FWH,
    };
    ```

To view, visit change 73039. To unsubscribe, or for help writing mail filters, visit settings.