Attention is currently required from: Nico Huber, Thomas Heijligen.

Patch set 3:Code-Review -1

View Change

1 comment:

• File meson.build:

  • Patch Set #3, Line 357: error('RAW access is not available on non-x86 platforms. Disable the programmer which needs it. Use `meson build -Dpciutils=false -Dconfig_rayer_spi=false`')

    Well, the comment about ARM is not wrong. But I have to admit it's misleading […]

    I hadn't realized that the Meson configuration had diverged so far from the Makefile; I've remedied that in https://review.coreboot.org/c/flashrom/+/61287 by copying the overall structure used in the Makefile.

    Since the x86 hwaccess headers are included in some non-x86 builds as part of the internal programmer, they do still need changes in order to build for non-x86 systems (even with the Makefile, though I was unable to actually cross-compile with the Makefile for seemingly pkg-config related reasons). I've fixed that in https://review.coreboot.org/c/flashrom/+/61194.

    Chromium uses Meson for all builds of flashrom, so removing the support would be unhelpful for us. I am not familiar with any conversation that came with its initial introduction, but I assume there was sufficient agreement that it's worth having.

To view, visit change 61198. To unsubscribe, or for help writing mail filters, visit settings.