Attention is currently required from: Anastasia Klimchuk.

Patch set 17:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #16:

    Just out of curiosity I ran the test case from here https://review.coreboot. […]

    Read also reaches 50% for the second command:
    ```
    Found Winbond flash chip "W25Q128.V" (16384 kB, SPI) on dummy.
    Reading old flash chip contents...
    [READ: 100%]...done.
    Updating flash chip contents...
    [READ: 50%][ERASE: 50%][WRITE: 100%]...Erase/write done from 0 to ffffff
    Verifying flash...
    [READ: 100%]...VERIFIED.
    ```
    Erasure is probably the result of selecting more fine-grained erasure functions in `erasure_layout.c`. Not sure about reads.

• File flashrom.c:

  • Patch Set #13, Line 1270: // FIXME: round up to granularity?

    Okay so I will close this (and the other one). […]

    Sure.

To view, visit change 84439. To unsubscribe, or for help writing mail filters, visit settings.