Patch Set 2:

Hi, Philipp mentioned that you had to tell flashrom that your device is
not a laptop? If that is still the case, can you provide a verbose log
please. I've reviewed the respective chipset_enable code against the ICL
datasheet but couldn't find any issue.

No, we first tried that before adding it as an target. Here is my logging:

mimoja@mimoja-Razer-Blade-Stealth-13-Late-2019:~/flashrom$ sudo ./flashrom -p internal -r icelake_readtest.bin
flashrom v1.1-rc1-126-g9a4f1d6 on Linux 5.3.0-24-generic (x86_64)
flashrom is free software, get the source code at

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
No DMI table found.
Found chipset "Intel Ice Lake U Premium".
Enabling flash write... SPI Configuration is locked down.
Enabling hardware sequencing because some important opcode is locked.
Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000.
Reading flash... done.

Also I renamed all occurences to "Ice Lake" now.

View Change

To view, visit change 37987. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6227d32f4476420cf1aeec37ebd4b7648e0b3d15
Gerrit-Change-Number: 37987
Gerrit-PatchSet: 3
Gerrit-Owner: Mimoja <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Mimoja <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: Philipp Deppenwiese <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Nico Huber <>
Gerrit-Comment-Date: Mon, 06 Jan 2020 15:57:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment