[...]
By sorting and diffing each of {orig,sorted}_entries files, I was able to verify that for every line in the orig_entries file there was an identical line in the sorted_entries file.

This shows that the entries in the before and after versions of flashchips.c are textually identical, apart from their order.

Thanks Alan for the elaborate description. However, my inner stickler
says that such checking should be left to the reviewer. My second idea
was pretty much like what you did with awk, so I had to come up with
something else:
I used `csplit` to extract the entries and some sed-foo to name each
file after the vendor-chip and compared the resulting directories with
`diff -r`: no complaints :)

I guess all that together is enough testing.

Patch set 7:Code-Review +2

View Change

To view, visit change 33931. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75a99583592526f60ba5264e92391bf8b1213b20
Gerrit-Change-Number: 33931
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 05 Jul 2019 22:47:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment