Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons, Alexander Goncharov.

6 comments:

Patchset:
- Patch Set #11:
  Hi Angel, thanks for your feedback. I both addressed your remarks and also fixed the regression with the `programmer_entry` struct.
File dirtyjtag_spi.c:
- Patch Set #10, Line 79: unsigned char *
  Doesn't this drop the `const` property of the data pointed by the pointer? Shouldn't it be `const un […]
  `libusb_bulk_transfer`'s data parameter takes a non-const pointer (because this function can be both used for read & write transactions) hence the explicit cast.
- Patch Set #10, Line 152: 30 * i
  This is because each transfer is 30 bytes, right? How about addding a constant inside the loop: […]
  Each transfer is not exactly 30 bytes, they can have at most 30 bytes of payload. I'll use the constant though, it can make the code easier to read.
- Patch Set #10, Line 154: (const char *)transfer_buffer
  Why are there casts here and inside the functions themselves? As these functions' signatures do not […]
  Fixed dirtyjtag_send/_received function parameter types
- Patch Set #10, Line 160: i * 30
  ditto
  Done
- Patch Set #10, Line 319:
```
.map_flash_region	= fallback_map,
	.unmap_flash_region	= fallback_unmap,
	.delay			= internal_delay,
```
  Please remove
  Done

To view, visit change 67878. To unsubscribe, or for help writing mail filters, visit settings.