Code looks good, how well was the rebase tested?

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 2: Author: Mike Banon <mikebdp2@gmail.com>

    As a courtesy, you should reset the author to Paul, or use
    his commits from [1] as basis.

    [1] http://git.code.paulk.fr/gitweb/?p=flashrom.git;a=shortlog;h=refs/heads/next

  • Patch Set #1, Line 7: [v4,1/6]

    Please remove this tag.

  • Patch Set #1, Line 17: Signed-off-by: Mike Banon <mikebdp2@gmail.com>

    Please also keep original Signed-off-by lines.

• File flashrom.c:

  • Patch Set #1, Line 762: static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran, const uint8_t erased_value)

    line is too long (112 chars limit)

  • Patch Set #1, Line 792: int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value)

    line is too long

To view, visit change 23258. To unsubscribe, or for help writing mail filters, visit settings.