Nico Huber has posted comments on this change. ( https://review.coreboot.org/23258 )
Change subject: [v4,1/6] Add support for selecting the erased bit value with a flag ......................................................................
Patch Set 1:
(5 comments)
Code looks good, how well was the rebase tested?
https://review.coreboot.org/#/c/23258/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23258/1//COMMIT_MSG@2 PS1, Line 2: Author: Mike Banon mikebdp2@gmail.com As a courtesy, you should reset the author to Paul, or use his commits from [1] as basis.
[1] http://git.code.paulk.fr/gitweb/?p=flashrom.git;a=shortlog;h=refs/heads/next
https://review.coreboot.org/#/c/23258/1//COMMIT_MSG@7 PS1, Line 7: [v4,1/6] Please remove this tag.
https://review.coreboot.org/#/c/23258/1//COMMIT_MSG@17 PS1, Line 17: Signed-off-by: Mike Banon mikebdp2@gmail.com Please also keep original Signed-off-by lines.
https://review.coreboot.org/#/c/23258/1/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23258/1/flashrom.c@762 PS1, Line 762: static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran, const uint8_t erased_value) line is too long (112 chars limit)
https://review.coreboot.org/#/c/23258/1/flashrom.c@792 PS1, Line 792: int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value) line is too long