Attention is currently required from: Nico Huber, Edward O'Callaghan.

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 10: TEST=dedede with `flashrom -p internal --flash-size`.

    Any other tests, e.g. reading? If the ME region is locked, you can still read the other regions. […]

    The test I've suggested will most likely not work because the IFD chipset detection is not complete. See Nico's comment.

• File ich_descriptors.c:

  • Patch Set #4, Line 1064: case CHIPSET_JASPER_LAKE:

    It's a switch/case on `guess`. The guessing code wasn't updated AFAICS.

    The `guess_ich_chipset_from_content()` function was updated for Elkhart Lake. I would come up with a way to detect Jasper Lake, but the damn SPI programming guide is not publicly available! 😡

To view, visit change 62282. To unsubscribe, or for help writing mail filters, visit settings.