Brian Norris has uploaded this change for review.

View Change

flashrom_tester: Correct "WP screw" message

flashrom_tester prints hints on how to modify hardware write protect
state as follows:

...
 > connect the battery (and/or open the WP screw)
...
 > disconnect the battery (and/or open the WP screw)
...

The first advice should be "[...] close the WP screw".

TEST=`flashrom_tester --flashrom_binary=$(which flashrom) \
        internal Erase_and_Write Fail_to_verify`

Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
---
M util/flashrom_tester/src/utils.rs
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/82083/1

diff --git a/util/flashrom_tester/src/utils.rs b/util/flashrom_tester/src/utils.rs
index 4e8dd7c..b43cf97 100644
--- a/util/flashrom_tester/src/utils.rs
+++ b/util/flashrom_tester/src/utils.rs
@@ -103,6 +103,7 @@
     // The easist way to toggle the hardware write-protect is
     // to {dis}connect the battery (and/or open the WP screw).
     let s = if dis { "dis" } else { "" };
+    let screw_state = if dis { "open" } else { "close" };
     // Print a failure message, but not on the first try.
     let mut fail_msg = None;
     while dis == get_hardware_wp()? {
@@ -112,7 +113,7 @@
         fail_msg = Some(format!("Hardware write protect is still {}!", !dis));
         // The following message is read by the tast test. Do not modify.
         info!("Prompt for hardware WP {}able", s);
-        eprintln!(" > {}connect the battery (and/or open the WP screw)", s);
+        eprintln!(" > {}connect the battery (and/or {} the WP screw)", s, screw_state);
         pause();
     }
     Ok(())

To view, visit change 82083. To unsubscribe, or for help writing mail filters, visit settings.