Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
cli_classic: Replace programmer_shutdown() with libflashrom call

flashrom_programmer_shutdown(NULL) is an equiv call
to programmer_shutdown() however this further decouples
cli from flashrom core logic at link-time, prefering to
instead enter via libflashrom instead.

BUG=none
TEST=`make`.

Change-Id: Ie194fa2e891797a29d05d7e9d0c7226fd62c0679
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/61584
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M cli_classic.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cli_classic.c b/cli_classic.c
index 3391af5..4a5f298 100644
--- a/cli_classic.c
+++ b/cli_classic.c
@@ -957,7 +957,7 @@
out_release:
flashrom_layout_release(layout);
out_shutdown:
- programmer_shutdown();
+ flashrom_programmer_shutdown(NULL);
out:
for (i = 0; i < chipcount; i++) {
flashrom_layout_release(flashes[i].default_layout);

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 61584. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie194fa2e891797a29d05d7e9d0c7226fd62c0679
Gerrit-Change-Number: 61584
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged