Attention is currently required from: Xiang Wang, Stefan Reinauer.
Patch set 2:Code-Review +1
13 comments:
File .gitignore:
Patch Set #2, Line 12: programmer_enum.h
programmer_table.h
Patchset:
Very cool.
File Makefile:
programmer_table.o
File flashrom.c:
Patch Set #2, Line 43: #include "programmer_table.c"
This greatly improves things so thank you for working on this!
One minor thing here, instead of including the C file how about compile it as an object and have the table defined in programmer_table.h ?
File meson.build:
Patch Set #2, Line 364: srcs += 'programmer.c'
\n
srcs += 'programmer_table.c'
File programmer.h:
Patch Set #2, Line 27: programmer_enum.h"
programmer_table.h
File util/generator_programmer_enum.sh:
Patch Set #2, Line 1: #! /bin/bash
#!/usr/bin/sh
Flashrom works on a number of non-Linux systems and I don't think you precisely need bash here.
Patch Set #2, Line 17: programmer_enum
programmer_table.h
Patch Set #2, Line 18: ENUM_PROGRAMMER_H
__PROGRAMMER_TABLE_H__
extern const struct programmer_entry programmer_table[];
Patch Set #2, Line 30: programmer_enum.h
programmer_table.h
Patch Set #2, Line 37: programmer_enum.h
programmer_table.h
/* __PROGRAMMER_TABLE_H__ */
To view, visit change 49599. To unsubscribe, or for help writing mail filters, visit settings.