Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Patch set 2:Code-Review +2
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 21935: .voltage = {2700, 3600},
I wanted to ask, why you set minimum voltage as 2.7 , I saw in datasheet it says `Full voltage range: 2.3-3.6V` ? Is there a reason you set 2.7 and not 2.3 ?
To view, visit change 83182. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad
Gerrit-Change-Number: 83182
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk <ssunkkan@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 25 Jun 2024 06:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes