Anastasia Klimchuk has uploaded this change for review.

View Change

raiden_debug_spi: Use new API to register shutdown function

This allows programmer to register shutdown function in spi_master
struct, which means there is no need to call register_shutdown in init
function, since this call is now a part of register_spi_master.

As a consequence of using new API, two things are happening here:
1) No resource leakage anymore in case register_shutdown() would fail,
2) Fixed propagation of register_spi_master() return values.

TRY TO TEST ME ON HW

BUG=b:185191942
TEST=test in CB:57918

Change-Id: I8927224779f24d1fda088991337e54d7272775a6
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
---
M raiden_debug_spi.c
1 file changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/57975/1
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c
index 40090f2..d9ca565 100644
--- a/raiden_debug_spi.c
+++ b/raiden_debug_spi.c
@@ -1298,6 +1298,7 @@
.read = default_spi_read,
.write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
+ .shutdown = raiden_debug_spi_shutdown,
};

static int match_endpoint(struct libusb_endpoint_descriptor const *descriptor,
@@ -1613,10 +1614,7 @@
return SPI_GENERIC_ERROR;
}

- register_spi_master(spi_config, data);
- register_shutdown(raiden_debug_spi_shutdown, data);
-
- return 0;
+ return register_spi_master(spi_config, data);
}

const struct programmer_entry programmer_raiden_debug_spi = {

To view, visit change 57975. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8927224779f24d1fda088991337e54d7272775a6
Gerrit-Change-Number: 57975
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: newchange