Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #22, Line 56: struct wp_chip_config *cfg

    Only realized this now: this requires the caller to know the size of
    `struct wp_chip_config` which is currently not given by `libflashrom.h`.
    IMO, we should use dynamic allocation instead, like in the rest of the
    API. It will require yet another de-allocation function, but having a
    clean, consistent API seems worth it.

To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.