13 comments:
Patch Set #5, Line 675: CONFIG_LSPCON_I2C_SPI ?= yes
Sorry forgot to make this as false. Will update on next iteration.
Patch Set #4, Line 39: #define SWSPI_WDATA_CLEAR_STATUS
How about adding an extra space between `#define` and the macro name? […]
Done
byte
Done
Patch Set #4, Line 314: wait_100_ms
wait_100ms
Done
Patch Set #4, Line 314: 100000000
`(unsigned)1e8` is more readable.
Done
Patch Set #4, Line 333: uint8_t command_byte1[] = { ROMADDR_BYTE1, (offset >> 8) & 0xff };
Given ROMADDR_BYTE1 and ROMADDR_BYTE2 are adjacent, can this not be done in a single write? Otherwis […]
Yes this can be done in a single write, I just want to separate them to make this clear. I will update this to use write_register if that's fine.
Patch Set #4, Line 365: write_buffer[0] = 0
Why the special treatment for position zero?
I think it is the requirement for i2c data transfer to write the start offset before the write data, this is useful if the write has to be done slowly like 32 byte a time. Also make two separate write that send 0 first and followed by write data does not work. I would assume we will need to keep this, does it make sense?
Are you sure about these?
Actually no, I have go through the code and looks like that applied to the send_command method eventually and thus this max value should be 16. While for the max write, I notice the value get passed in eventually as out_len here: https://github.com/flashrom/flashrom/blob/ef78de4a21323b8c459337356289218211f2c5ce/spi25.c#L432, that means the limit should be 16 - 4 is that correct?
stopped
Done
(void)
Done
SPI
Done
Do we perhaps want to default to false as the i2c helper only currently supports Linux and thus woul […]
Done
Shouldn't this be guarded like on line 579?
Done
To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.