Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.
9 comments:
Commit Message:
Hi Xiang, So I think what Angel and I are saying here is that the rational should be explained in mo […]
Sorry I misunderstood.
File bitbang_spi.c:
}
master->set_sck(sck);
master->set_mosi(mosi);
}
spurious changes?
This is the spi timing requirement, the mosi change should be before the sck change when sending data
ditto
Done
Patch Set #6, Line 89: for (int i = 0; i < 8; i++) {
Leave style changes to another commit and out of the meat of this one, it gets in the way of reviewi […]
Done
Patch Set #6, Line 90: ret = ret << 1;
same here, just leave as `ret <<= 1;` in this commit
Done
Patch Set #6, Line 107: for (int i = 0; i < 8; i++) {
ditto
Done
Patch Set #6, Line 119: val = val << 1;
ditto
Done
programmer_delay(master->half_period);
bitbang_spi_set_cs(master, 0);
programmer_delay(master->half_period);
this feels like its own little patch.
move to https://review.coreboot.org/c/flashrom/+/49262
char *mode = extract_programmer_param("mode");
if (mode) {
if (strlen(mode)) {
char *endptr;
int v = strtol(mode, &endptr, 0);
if (mode == endptr || v > 3 || v < 0) {
msg_perr("bitbang spi only work with mode 0-3\n");
free(mode);
return ERROR_FLASHROM_BUG;
}
cpol = (v >> 1) & 1;
cpha = (v >> 0) & 1;
}
free(mode);
}
static parse_mode function that takes `(&int, &int)` as a type ?
Done
To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.