Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #1:
This is not the greatest solution, but the only thing I found that worked. […]
I did a little more digging, this seems to be a bug with lcov, not meson: https://github.com/linux-test-project/lcov/issues/168
So without this patch `ninja coverage` wont work if you have lcov installed. I updated the documentation on https://review.coreboot.org/c/flashrom/+/69266
We could define our own coverage target like : https://review.coreboot.org/c/flashrom/+/69268
To view, visit change 69265. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibba93037831fc0ed526f701cbe360b5a493895d1
Gerrit-Change-Number: 69265
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 08 Nov 2022 04:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn <evanbenn@google.com>
Gerrit-MessageType: comment