Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
3 comments:
File dummyflasher.c:
/* Remove the #define below if you don't want SPI flash chip emulation. */
#define EMULATE_SPI_CHIP 1
> Just to confirm, you mean, let's assume (EMULATE_CHIP && EMULATE_SPI_CHIP) always true and drop th […]
Re-reading myself again, I should have phrased my thoughts better. And now I understand better after your reply, thanks.
What I was wondering, is if EMULATE_SPI_CHIP is undefined then some chunks of code won't be included at all (chunks that are wrapped with #if EMULATE_SPI_CHIP). Is this a valid/useful case to keep? This option does not exist anymore after CB:55265 (those chunks of code are always included), but if it is useless then of course no point to keep it.
File dummyflasher.c:
Patch Set #4, Line 994: dummy_buses_supported
It is not only used for init. But there lies the answer: it's used get the […]
Oh get_data_from_context() got removed recently (just as you said, it was unnecessary), so now dummy_buses_supported is only used in init time.
File dummyflasher.c:
Patch Set #5, Line 653: #if EMULATE_SPI_CHIP
CB:55265
thank you! I will rebased once CB:55265 and CB:55266 are submitted.
To view, visit change 54748. To unsubscribe, or for help writing mail filters, visit settings.