Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Peter Marheine.

Patch set 3:Code-Review +1

View Change

3 comments:

• File tests/init_shutdown.c:

  • Patch Set #3, Line 234: // Only access to I2C address 0x4a is expected

    Do we really have one line comments, I am not sure... I thought it is /* */ everywhere?

  • Patch Set #3, Line 252:

    else if (sz == 1 || sz == 2)
    		return sz;
    	else
    		return -1;
    

    Since you return, else if, and else is not needed

  • Patch Set #3, Line 267:

    io_mock_register(&realtek_mst_io);
    	run_lifecycle(state, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0");
    	io_mock_register(NULL);
    

    This is a small thing, but for consistency and readability, if you could add empty lines between io_mock_register and run_lifecycle? (like in the other tests)

To view, visit change 56911. To unsubscribe, or for help writing mail filters, visit settings.