Attention is currently required from: qianfan, Nicholas Chin, Angel Pons.

View Change

2 comments:

• File ch347t_spi.c:

  • Patch Set #5, Line 169:

    if (n > CH347_MAX_DATA_WRITE)
    			n = CH347_MAX_DATA_WRITE;
    

    I can't find a better idea, could you please give me some advices?

    Oh wait, this is chunking the transfers, right? It's a bit confusing because the chunk size goes through `libusb_bulk_transfer()`. If so, then this seems reasonable. No idea if flashrom has a `MIN(a, b)` macro somewhere; if it does, then one could do:

     size_t n = MIN(sz, CH347_MAX_DATA_WRITE);

  • Patch Set #5, Line 279: memset(&csctrl, 0, sizeof(csctrl));

    OK

    Thanks!

    Note that you should mark comments you've addressed (like this one) as resolved. If you're not sure if you've addressed the requests, you can ask others to acknowledge what you've changed.

To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.