Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner.
View Change
1 comment:
File board_enable.c:
Patch Set #2, Line 2339: return 0;
That would be one of the little changes, e.g. make calling
register_shutdown() optional, then the tool would have to call
pcidev_shutdown() directly.
Except that it's used four times in the file and there is also one use of extract_programmer_param(). These need to not be mentioned at all in order to get rid of the symbols in object files. And then there is invocation of print() from libflashrom.c, which in turn depends on flashrom.c...
That said, you're welcome to give it a try :) or suggest alternatives. We might also choose to write a completely standalone tool for unlocking if all our attempts here fail.
To view, visit change 56023. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Comment-Date: Thu, 07 Apr 2022 20:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment