Attention is currently required from: Sam McNally, Subrata Banik, Rizwan Qureshi, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File chipset_enable.c:
Patch Set #10, Line 2154: {0x8086, 0x7aa4, B_S, DEP, "Intel", "Alder Lake-S", enable_flash_pch600},
No, he said it can be removed.
what is the point of adding unused PCI id when we don't have ADL-S support in general in open-source platform.
What do you mean? That your chromeos firmware efforts don't include ADL-S?
If yes, what does it matter to flashrom?
To view, visit change 62251. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf
Gerrit-Change-Number: 62251
Gerrit-PatchSet: 11
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Reka Norman <rekanorman@chromium.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 14:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment