View Change
1 comment:
Patchset:
Patch Set #17:
There's a typo in the Makefile. We should be adding to FEATURE_FLAGS not FEATURE_CFLAGS.
Without this, the interface *is never (has never?) been loaded*
I wrote this up as an issue in github.
https://github.com/flashrom/flashrom/issues/296
Now, when this bug is fixed, the interface doesn't seem to work. I'm reluctant to debug if this has never been run or tested by people more knowledgeable and skilled than me!
To view, visit change 67878. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 17
Gerrit-Owner: Jean THOMAS <virgule@jeanthomas.me>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alexander Goncharov <chat@joursoir.net>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: David Williams
Gerrit-Comment-Date: Sun, 04 Jun 2023 23:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment