Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
Patch set 37:Code-Review +1
View Change
1 comment:
File writeprotect.c:
Patch Set #37, Line 157: return FLASHROM_WP_ERR_CHIP_UNSUPPORTED;
This looks suspiciously redundant with the check in chip_supported().
Will this function be used in a different context later, so this check
here would be needed?
To view, visit change 59183. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5a1dfcf384166b1bac319d286306747e1dcaa000
Gerrit-Change-Number: 59183
Gerrit-PatchSet: 37
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 16:42:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment