Attention is currently required from: Alan Green, Edward O'Callaghan, Angel Pons, Samir Ibradžić.

Nico Huber would like Alan Green, Edward O'Callaghan, Angel Pons and Samir Ibradžić to review this change.

View Change

Revert "ft2232_spi: Fix broken GPIOL cs_bits state (#126)"

This reverts commit a43e44b6abbe8381be3f3dd20a430973cf8b8ab5.

Nothing was broken. So this breaks everything. Well, actually only
the `csgpiol` parameter. But that is very obvious.

`csgpiol` was added to use a GPIO pin as /CS. But this change impli-
citly hardcoded /CS to ADBUS3.

Change-Id: I9ecdfe227585dda74658c16c96a57dd42d1d78b4
Signed-off-by: Nico Huber <nico.h@gmx.de>
---
M ft2232_spi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/55693/1
diff --git a/ft2232_spi.c b/ft2232_spi.c
index 2eb735a..4a3a5a4 100644
--- a/ft2232_spi.c
+++ b/ft2232_spi.c
@@ -225,7 +225,7 @@

msg_pspew("Assert CS#\n");
buf[i++] = SET_BITS_LOW;
- buf[i++] = ~ 0x08 & spi_data->cs_bits; /* assert CS (3rd) bit only */
+ buf[i++] = 0 & ~spi_data->cs_bits; /* assertive */
buf[i++] = spi_data->pindir;

/* WREN, OP(PROGRAM, ERASE), ADDR, DATA */

To view, visit change 55693. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9ecdfe227585dda74658c16c96a57dd42d1d78b4
Gerrit-Change-Number: 55693
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-Attention: Alan Green <avg@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-MessageType: newchange