I'm generally ok with this. But the whole layout stuff should be less
error-prone (e.g. sanity check for conflicting region names), before
we do it.

Also, looking at the diff-stat, I know this is supposed to save some
ugly code in the next commit, but it seems to move the problems else-
where. Generally I think, we should focus on a clean refactoring in-
stead of wasting time writing and bikeshedding shortcuts.

Patch set 5:Code-Review +1

View Change

To view, visit change 23678. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13
Gerrit-Change-Number: 23678
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 14:18:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes