Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Alexander Goncharov.
11 comments:
Commit Message:
Patch Set #7, Line 7: tree: provide flashrom context into programmer's delay
It's not passed to the programmers anymore
Add the flashrom context to the delay function declaration, which
located in `struct programmer_entry`.
Doesn't apply anymore. Also, there is not *that* delay function. So mention the name `programmer_delay`.
Patch Set #7, Line 14: TOPIC=register_master_api
How is this patch related to this topic?
File amd_imc.c:
/* flashctx is not completely ready during init, so it's not
* needed (NULL). */
Same here
File atavia.c:
/* flashctx is not needed (NULL) because atavia does
* not use it in its delay function. */
Same here
File dediprog.c:
/* flashctx not needed (NULL) because dediprog does not use it in its
* delay function. */
Same here
File flashrom.c:
Patch Set #5, Line 220: void programmer_delay(const struct flashctx *flash, unsigned int usecs)
The commit message to this patch is hard to have both ways, it is either very forward looking and me […]
My comment is related to an older patch set in which the function was reworked while the commit message just says "pass flashctx to functions", which was wrong.
However, the commit message still doesn't fit to the recent patch set. See my other comments.
File ichspi.c:
flashctx is not needed (NULL) because ichspi does not use
* it in its delay function. */
Same here
File pony_spi.c:
flashctx not needed (NULL) because pony_spi does not
* use it in its delay function.
The parameter should be documented at the function declaration, not in the programmers code.
Also flashctx is not
* completely ready during init anyway.
This doesn't add much value. So please remove.
File raiden_debug_spi.c:
* flashctx not needed (NULL) because raiden_debug_spi does not
* use it in its delay function. Also flashctx is not
* completely ready during init anyway. */
Same here
To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.