Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #1, Line 93: __attribute__((deprecated("Use flashrom_set_progress_callback_v1 instead")));

    I couldn't do it, got confused along the way - maybe I just went into the wrong rabbit hole? […]

    I think we'd have to look at preprocessor symbols that tell us about the compiler and version, if anything. At this point it's probably safe to assume any reasonable version of GCC or Clang supports the `deprecated` attribute, but if there's any other compiler lurking out there that we might care about it might need special handling.

    It might make the most sense just to go ahead with `deprecated`, and adjust if anybody discovers a compiler they want to use that doesn't understand it.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.